Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #2379

Merged
merged 1 commit into from
May 12, 2017
Merged

Fixed typo #2379

merged 1 commit into from
May 12, 2017

Conversation

scari
Copy link

@scari scari commented May 12, 2017

Reasons for making this change:

The typo using a comma instead of a dot.

@shiftkey
Copy link
Member

@scari nice spot! Thanks!

@shiftkey shiftkey merged commit 44cbb36 into github:master May 12, 2017
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
@greyltc
Copy link

greyltc commented Dec 14, 2023

Hey, @scari, @shiftkey, I don't think that was a typo. It was there to ignore files with the literal extension ,cover.

Here's the code that makes files with that extension: https://github.com/nedbat/coveragepy/blob/8841bdd33d9bda41e5fd246479e1e739fb04bb87/coverage/annotate.py#L84
maybe the bug's there or maybe the comma is intended, maybe @nedbat knows.

@nedbat
Copy link

nedbat commented Dec 14, 2023

Coverage.py does indeed create files with a suffix of ,cover with a comma. It's always done that, so I don't know the original reason.

@nedbat
Copy link

nedbat commented Dec 15, 2023

Hmm, actually, the ,cover files are matched by the next line: *.py,cover. I'm not sure what the ",cover" or ".cover" line is meant to match.

@scari
Copy link
Author

scari commented Dec 20, 2023

Thanks for revisiting this and mentioning me, @greyltc

You're right. the original ,cover meant to be there to ignore files with the exact extension. ba6f0a9

This PR shouldn't have been merged.

@scari
Copy link
Author

scari commented Dec 20, 2023

I guess this commit 3b445eb is bringing back ,cover as I mistakenly renamed it. @nedbat

scari added a commit to scari/gitignore that referenced this pull request Dec 20, 2023
rectify a mistake that renames a valid record `,cover` and remove a duplicate line for the same purpose. thx @greyltc
ref. github#2379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants