Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the availability of the development version. #1537

Merged
merged 2 commits into from
Aug 15, 2017

Conversation

mareksuscak
Copy link
Contributor

@mareksuscak mareksuscak commented Aug 14, 2017

I checked the Chocolatey Gallery and it doesn't seem like there's a prerelease of hub. So I haven't documented that but Chocolatey itself supports prereleases.

README.md Outdated
@@ -33,6 +33,12 @@ git version 1.7.6
hub version 2.2.3
```

if you want to use the latest unstable version, use:
Copy link
Owner

@mislav mislav Aug 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please start sentences with a capital letter. That would be "If".

  2. A prerelease version is not necessarily "unstable". They pass all CI tests. It's just that their feature set changes often and some flags might be removed or renamed.

    Also, nobody really wants to "use the latest unstable version". If you phrase it like that, that sounds like there is no benefit to using --devel, and that there is only a negative consequence: instability. But, the actual benefit is that you gain access to new features quicker. So, let's instead phrase it using a language that reveals a benefit that a user might get from using the --devel flag: “If you want to get access to new hub features earlier and help with its development by reporting bugs, you can install the prerelease version”.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An excellent feedback, thank you. I'll incorporate the language.

PS: I considered phrasing it the same way as you've just proposed but wasn't really sure if that is true so thanks for clearing that up.

@mareksuscak
Copy link
Contributor Author

This is now ready to be re-reviewed @mislav.

@mislav mislav merged commit a45f457 into mislav:master Aug 15, 2017
@mislav
Copy link
Owner

mislav commented Aug 15, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants