-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to specify body from command-line #183
Conversation
There is no way to specify a body for a pull-request using hub unless you omit the title and let hub open an editor for you. This commit adds the -B parameter to specify a body (and adds -t for title for consistency's sake).
+1 |
Hey @vhata, sorry this didn't get my attention for such a long time. Generally I'm in favor of being to specify all things via command-line. I would like to have ability to pull this information from a file or STDIN, too. I'll pull your code and work from there the next time I work on hub. You did a good job updating the documentation but you forgot tests. |
I added two commits to @vhata's commit.
I didn't make another pr because I want to respect @vhata's original commit. How about it? |
You could have opened another pull request which includes vhata's commit plus your own. But it's OK this way as well; it's not hard for me to pull all this. But I stopped maintaining unit tests in I'm still not sure about the How about emulating the interface of
|
See just referenced commit for my implementation of Basically, instead of having to pass in 2 arguments (title & body) you just pass one big string (either via argument, stdin or file) where the first block of text is the title and everything else is body. |
This ability is same as mislav#183 (made by @vhata) and mislav#256 (made by @banyan). The name of `-m` option imitates `git commit`. Add test (cucumber feature), too.
Thank you for your fast work! Just my two cents, I think the read_msg method is not necessary because read_editmsg can handle both |
Landed in master! |
There is no way to specify a body for a pull-request using hub unless
you omit the title and let hub open an editor for you.
This commit adds the -B parameter to specify a body (and adds -t for
title for consistency's sake).