Add the ability to specify body from command-line

[vhata]

There is no way to specify a body for a pull-request using hub unless
you omit the title and let hub open an editor for you.

This commit adds the -B parameter to specify a body (and adds -t for
title for consistency's sake).

[danielribeiro]

+1

[mislav]

Hey @vhata, sorry this didn't get my attention for such a long time. Generally I'm in favor of being to specify all things via command-line. I would like to have ability to pull this information from a file or STDIN, too. I'll pull your code and work from there the next time I work on hub.

You did a good job updating the documentation but you forgot tests.

[kyanny]

@mislav

I added two commits to @vhata's commit.

• Fix broken test against ebc12fa
  • kyanny@36a4eda
• Add test against -B option and -t option.
  • kyanny@e290567

I didn't make another pr because I want to respect @vhata's original commit.
You can apply my commits via https://github.com/kyanny/hub/commit/36a4eda0445c6f158bead386a1a0ad41f087a601.patch and https://github.com/kyanny/hub/commit/e290567da108e192e6c479aaa78100e186201f73.patch.

How about it?

[mislav]

You could have opened another pull request which includes vhata's commit plus your own. But it's OK this way as well; it's not hard for me to pull all this. But I stopped maintaining unit tests in test/ directory and instead started porting everything to Cucumber in features/ directory. It would be great if you found the time to do the same with the couple of tests you added/edited here in your commits.

I'm still not sure about the -B flag naming. I would rather name it --body. I'm also thinking whether title and body separation is necessary. Why not just take a single argument and extract the 1st line of it as "title" and the rest as "body"? I would also like that there's ability to take in the contents of a file or stdin.

How about emulating the interface of git commit?

• hub pull-request -F <file> - reads title & body from a file
• hub pull-request -F - - from stdin
• hub pull-request -m "my text" - from argument

[mislav]

See just referenced commit for my implementation of -F and -m support. I plan to release this. Please comment if you have any thoughts.

Basically, instead of having to pass in 2 arguments (title & body) you just pass one big string (either via argument, stdin or file) where the first block of text is the title and everything else is body.

[kyanny]

@mislav

Thank you for your fast work!
I just did almost same thing at https://github.com/kyanny/hub/compare/pr-with-body but your's looks better.

Just my two cents, I think the read_msg method is not necessary because read_editmsg can handle both STDIN and FILE with tiny fixes.

[mislav]

Landed in master!