-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a command for listing all open pull requests #351
Conversation
You can run: `hub pulls` And get output like: ``` jm3 - Add correct hub alias for fish shell (fixes mislav#248) mislav#350 pchw - add pull-request to open-browser option mislav#344 mmozuras - Figure out default branch for the project instead of just using master mislav#326 timmow - Add info on using with Github Enterprise mislav#297 jianli - browse -b flag mislav#258 ```
Hi @radamant This looks good, although I'd like to have this with caching. I realize this complicates implementation a bit, but would lead to a much better experience. I would cache pull requests from every GitHub API response and the next time I'm requesting pulls, I would only request changes after the timestamp when cache was last made. Also, I'm not writing new unit tests anymore. All new tests should go under I was thinking of working on this myself. I'll keep this open until I either merge it or implement something equivalent. Thanks for your help! |
@mislav is there anything I can do to help get this merged? This feature is something my current team would use frequently and they are currently using my fork rather than canonical hub. |
To ship this feature, it needs:
Bonus features:
I don't expect you to do all this work. I'm going to do as much as I can, but I'll leave your contribution unmerged and open until I decide just how much (if any) of your code I will use. Your coworkers should in the meantime use your fork. |
@radamant I have no affiliation, but you might be interested in https://github.com/eduardolundgren/node-gh |
ping. |
No sense in pinging me :) I still didn't have time to implement this, but I will at some point. Everyone is welcome to beat me to it, if they take in consideration my thoughts above |
Consider adding an option for limiting the list to those pull requests that need conflict resolution on merge. Not sure whether and how this can be detected using the Github API. |
Closing this PR as it won't apply anymore since we nuked the Ruby implementation and replaced it with Go: #642. It's on our roadmap to provide a feature for listing issues/pulls, though. Stay tuned. |
You can run:
hub pulls
And get output like: