Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

remove htmlparser dependency #1277

Merged
merged 1 commit into from Jun 5, 2015
Merged

remove htmlparser dependency #1277

merged 1 commit into from Jun 5, 2015

Conversation

hugecannon
Copy link
Contributor

htmlparser no longer required

htmlparser no longer required
@hugecannon
Copy link
Contributor Author

Am I missing something or is this dependency unnecessary?

@technicalpickles
Copy link
Contributor

I don't see mention of it in the code. Have you tried running with your changes, without htmlparser in the package.json?

@hugecannon
Copy link
Contributor Author

I haven't tried running it, I just spotted it in passing 😄

technicalpickles added a commit that referenced this pull request Jun 5, 2015
remove htmlparser dependency
@technicalpickles technicalpickles merged commit 8c34360 into github:master Jun 5, 2015
@technicalpickles
Copy link
Contributor

We are actually moving away from adding scripts to repository in favor of separate npm packages per scripts. We have already stopped accepting new scripts, and will stop accepting pull requests on this repository after hubot 3.0.

See #1113 for details. If you are interested in maintaining this longer term, check npm in case someone already made a package for it, and if not, check out https://hubot.github.com/docs/scripting/ for creating a package of your own.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants