Skip to content

remove htmlparser dependency #1277

Merged
merged 1 commit into from Jun 5, 2015

2 participants

@hugecannon

htmlparser no longer required

@hugecannon hugecannon remove htmlparser dependency
htmlparser no longer required
5dbf914
@hugecannon

Am I missing something or is this dependency unnecessary?

@technicalpickles
GitHub member

I don't see mention of it in the code. Have you tried running with your changes, without htmlparser in the package.json?

@hugecannon

I haven't tried running it, I just spotted it in passing 😄

@technicalpickles technicalpickles merged commit 8c34360 into github:master Jun 5, 2015
@technicalpickles
GitHub member

We are actually moving away from adding scripts to repository in favor of separate npm packages per scripts. We have already stopped accepting new scripts, and will stop accepting pull requests on this repository after hubot 3.0.

See #1113 for details. If you are interested in maintaining this longer term, check npm in case someone already made a package for it, and if not, check out https://hubot.github.com/docs/scripting/ for creating a package of your own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.