Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

User right selector on 9gag #207

Merged
merged 1 commit into from Dec 9, 2011
Merged

Conversation

EnriqueVidal
Copy link
Contributor

This was an oversight, 9gag.coffe had the wrong css selectors, is there currently a better way to test the merging to master?

@tombell
Copy link
Contributor

tombell commented Dec 9, 2011

Easiest way to test is test the script locally on your own Hubot, or using the shell adapter

tombell added a commit that referenced this pull request Dec 9, 2011
@tombell tombell merged commit 055c519 into github:master Dec 9, 2011
@EnriqueVidal
Copy link
Contributor Author

I've been trying that, but with no luck, I added my custom coffeescript file to my hubot scripts folder restarted heroku and tried it, it was a no go, then I setup a static message and still nothing, what am I doing wrong?

@tombell
Copy link
Contributor

tombell commented Dec 9, 2011

You will need to clone your hubot from Heroku, add the script, commit the changes and re-push to Heroku. Also locally testing with the shell adapter is just as easy.

  • Clone hubot repo
  • npm install the dependencies
  • Add your script to src/scripts
  • bin/hubot

Then you'll have a REPL for testing commands.

@EnriqueVidal
Copy link
Contributor Author

Also should the version in this project package.json change whenever we change a script?

@tombell
Copy link
Contributor

tombell commented Dec 9, 2011

No, only when we make a new release.

amaltson pushed a commit to amaltson/hubot-scripts that referenced this pull request Jan 7, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants