Skip to content

Commit

Permalink
Bump hubot version to 2.5.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@tombell
tombell committed Apr 6, 2013
1 parent 4655aca commit a986f93
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "hubot",
"version": "2.4.8",
"version": "2.5.0",

"author": "hubot",

Expand Down
2 changes: 1 addition & 1 deletion src/templates/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},

"dependencies": {
"hubot": ">= 2.4.8",
"hubot": ">= 2.5.0",

This comment has been minimized.

Sign in to view

Copy link
@exalted

exalted Apr 16, 2013

Latest version is 2.4.8? Breaks npm install on Heroku…

This comment has been minimized.

Sign in to view

Copy link
@tombell

tombell Apr 16, 2013

Author Contributor

It doesn't, are you following the instructions in the README?

This comment has been minimized.

Sign in to view

Copy link
@exalted

exalted Apr 16, 2013

Yes, more precisely README for tag v2.5.0

This comment has been minimized.

Sign in to view

Copy link
@tombell

tombell Apr 16, 2013

Author Contributor

2.5.0 hasn't been released yet.

This comment has been minimized.

Sign in to view

Copy link
@tombell

tombell Apr 16, 2013

Author Contributor

You should follow these: https://github.com/github/hubot#getting-your-own

This comment has been minimized.

Sign in to view

Copy link
@exalted

exalted Apr 16, 2013

Out of the box that won’t work:

hubot --create foobar
env: coffee: No such file or directory

This comment has been minimized.

Sign in to view

Copy link
@exalted

exalted Apr 16, 2013

2.4.8 is released, but:

npm install fase on Heroku says:

Installing dependencies with npm
       npm http GET https://registry.npmjs.org/hubot-scripts
       npm http GET https://registry.npmjs.org/optparse/1.0.3
       npm http GET https://registry.npmjs.org/hubot
       npm http 200 https://registry.npmjs.org/optparse/1.0.3
       npm http GET https://registry.npmjs.org/optparse/-/optparse-1.0.3.tgz
       npm http 200 https://registry.npmjs.org/hubot-scripts
       npm http 200 https://registry.npmjs.org/hubot
       npm http GET https://registry.npmjs.org/hubot-scripts/-/hubot-scripts-2.4.3.tgz
       npm http GET https://registry.npmjs.org/hubot/-/hubot-2.4.8.tgz
       npm http 200 https://registry.npmjs.org/optparse/-/optparse-1.0.3.tgz
       npm http 200 https://registry.npmjs.org/hubot-scripts/-/hubot-scripts-2.4.3.tgz
       npm http 200 https://registry.npmjs.org/hubot/-/hubot-2.4.8.tgz
       npm ERR! cb() never called!
       npm ERR! not ok code 0
 !     Failed to install --production dependencies with npm
 !     Heroku push rejected, failed to compile Node.js app

This comment has been minimized.

Sign in to view

Copy link
@tombell

tombell Apr 16, 2013

Author Contributor

Did you create your hubot with hubot --create <path>?

This comment has been minimized.

Sign in to view

Copy link
@exalted

exalted Apr 16, 2013

If you install hubot with npm --global install hubot and then run hubot --create foobar you will get env: coffee: No such file or directory

This comment has been minimized.

Sign in to view

Copy link
@tombell

tombell Apr 16, 2013

Author Contributor

Could you open a proper issue, so we don't spam commit comments.

This comment has been minimized.

Sign in to view

Copy link
@exalted

exalted Apr 16, 2013

Sure! #477
"hubot-scripts": ">= 2.4.2"
},

Expand Down

0 comments on commit a986f93

Please sign in to comment.