Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Bump hubot version to 2.5.0

  • Loading branch information...
commit a986f930356697dbbaa3bf8796e2ec6aca006fbb 1 parent 4655aca
@tombell tombell authored
Showing with 2 additions and 2 deletions.
  1. +1 −1  package.json
  2. +1 −1  src/templates/package.json
View
2  package.json
@@ -1,6 +1,6 @@
{
"name": "hubot",
- "version": "2.4.8",
+ "version": "2.5.0",
"author": "hubot",
View
2  src/templates/package.json
@@ -24,7 +24,7 @@
},
"dependencies": {
- "hubot": ">= 2.4.8",
+ "hubot": ">= 2.5.0",
@exalted
exalted added a note

Latest version is 2.4.8? Breaks npm install on Heroku…

@tombell
tombell added a note

It doesn't, are you following the instructions in the README?

@exalted
exalted added a note

Yes, more precisely README for tag v2.5.0

@tombell
tombell added a note

2.5.0 hasn't been released yet.

@exalted
exalted added a note

Out of the box that won’t work:

hubot --create foobar
env: coffee: No such file or directory
@exalted
exalted added a note

2.4.8 is released, but:

npm install fase on Heroku says:

Installing dependencies with npm
       npm http GET https://registry.npmjs.org/hubot-scripts
       npm http GET https://registry.npmjs.org/optparse/1.0.3
       npm http GET https://registry.npmjs.org/hubot
       npm http 200 https://registry.npmjs.org/optparse/1.0.3
       npm http GET https://registry.npmjs.org/optparse/-/optparse-1.0.3.tgz
       npm http 200 https://registry.npmjs.org/hubot-scripts
       npm http 200 https://registry.npmjs.org/hubot
       npm http GET https://registry.npmjs.org/hubot-scripts/-/hubot-scripts-2.4.3.tgz
       npm http GET https://registry.npmjs.org/hubot/-/hubot-2.4.8.tgz
       npm http 200 https://registry.npmjs.org/optparse/-/optparse-1.0.3.tgz
       npm http 200 https://registry.npmjs.org/hubot-scripts/-/hubot-scripts-2.4.3.tgz
       npm http 200 https://registry.npmjs.org/hubot/-/hubot-2.4.8.tgz
       npm ERR! cb() never called!
       npm ERR! not ok code 0
 !     Failed to install --production dependencies with npm
 !     Heroku push rejected, failed to compile Node.js app
@tombell
tombell added a note

Did you create your hubot with hubot --create <path>?

@exalted
exalted added a note

If you install hubot with npm --global install hubot and then run hubot --create foobar you will get env: coffee: No such file or directory

@tombell
tombell added a note

Could you open a proper issue, so we don't spam commit comments.

@exalted
exalted added a note

Sure! #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
"hubot-scripts": ">= 2.4.2"
},
Please sign in to comment.
Something went wrong with that request. Please try again.