Merge pull request #432 from github/exit-on-errors

Exit on errors during startup

bin/hubot

@@ -98,6 +98,7 @@ else
               robot.loadHubotScripts scriptsPath, scripts
             catch err
               console.error "Error parsing JSON data from hubot-scripts.json: #{err}"
+              process.exit(1)
 
     externalScripts = Path.resolve ".", "external-scripts.json"
     Fs.exists externalScripts, (exists) ->
@@ -106,9 +107,10 @@ else
           if data.length > 0
             try
               scripts = JSON.parse data
-              robot.loadExternalScripts scripts
             catch err
               console.error "Error parsing JSON data from external-scripts.json: #{err}"
+              process.exit(1)
+            robot.loadExternalScripts scripts
 
     for path in Options.scripts
       if path[0] == '/'

src/robot.coffee

@@ -142,7 +142,8 @@ class Robot
         require(full) @
         @parseHelp "#{path}/#{file}"
       catch error
-        @logger.error "Unable to load #{full}: #{error}\n#{error.stack}"
+        @logger.error "Unable to load #{full}: #{error.stack}"
+        process.exit(1)
 
   # Public: Loads every script in the given path.
   #
@@ -180,6 +181,7 @@ class Robot
         require(pkg) @
       catch error
         @logger.error "Error loading scripts from npm package - #{error}"
+        process.exit(1)
 
   # Setup the Connect server's defaults.
   #
@@ -246,6 +248,7 @@ class Robot
       @adapter = require(path).use @
     catch err
       @logger.error "Cannot load adapter #{adapter} - #{err}"
+      process.exit(1)
 
   # Public: Help Commands for Running Scripts.
   #