Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Simple example in main README? #142

Closed
spier opened this issue Oct 14, 2023 · 7 comments · Fixed by #145
Closed

[docs] Simple example in main README? #142

spier opened this issue Oct 14, 2023 · 7 comments · Fixed by #145
Labels
documentation Improvements or additions to documentation

Comments

@spier
Copy link
Contributor

spier commented Oct 14, 2023

I noticed that after changes in #139 the main README.md does not contain a simple workflow example any more.
I believe that this file is also used for the documentation on the GHA marketplace?

When trying out a new GitHub Action, I tend to copy and paste a simple example from the documentation, and then adapt it to my purposes from there.

To do that, I find it unhandy if such a workflow example isn't too many clicks away.

I would therefore suggest to leave at least a basic example in the main README.md.

Not sure which example workflow would be the most simple to use? Maybe this one?
https://github.com/github/issue-metrics/blob/main/docs/example-workflows.md#fixed-time-example

@Okabe-Junya
Copy link
Contributor

I think it’s a great suggestion. Also, I believe this is the simplest example.

Removing the date calculation and fixing the search query would simplify things, but it might not be appropriate.

@spier
Copy link
Contributor Author

spier commented Oct 14, 2023

Thank you for the confirmation @Okabe-Junya!

What would you additionally thing of adding a screenshot to the README of how the resulting issue with the metrics report looks like? Maybe based on analytics of this repo here? :)

@Okabe-Junya
Copy link
Contributor

Okabe-Junya commented Oct 14, 2023

I think this is an excellent suggestion!! I am in favor of this proposal. From my research, it seems that similar actions also capture results and list them in the README.

We may need to determine the best way to capture results and possibly update documents like CONTRIBUTING.md.

@zkoppert zkoppert added the documentation Improvements or additions to documentation label Oct 16, 2023
@Okabe-Junya
Copy link
Contributor

Okabe-Junya commented Oct 17, 2023

@spier

May I create a PR for this issue? If you're already working on it, please let me know.

@spier
Copy link
Contributor Author

spier commented Oct 17, 2023

Go for it :)

@spier
Copy link
Contributor Author

spier commented Oct 18, 2023

@Okabe-Junya great changes in #145.
Looks fantastic in the marketplace as well :)

Did you decide against adding a screenshot of the resulting GitHub issue on purpose, as suggested above.
Or is this still something that might be worthwhile adding?

@Okabe-Junya
Copy link
Contributor

Thank you!!

I did not include screenshots in my PR. This was because I couldn't determine which repo would be appropriate or how best to capture the screenshots. However, I do think we should consider capturing the results and including them in the README. My decision to close this issue might not have been the best one (I set it to automatically close with the PR).

Let's discuss this in a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants