Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme #131

Closed
wants to merge 2 commits into from
Closed

Updated Readme #131

wants to merge 2 commits into from

Conversation

MihirKohli
Copy link
Contributor

@MihirKohli MihirKohli commented Sep 22, 2023

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@zkoppert
Copy link
Member

zkoppert commented Sep 27, 2023

@MihirKohli Thanks for opening this one! I don't think we want all of the .idea/ directory and content in here. Can you remove that from this pull request?

@zkoppert zkoppert added the documentation Improvements or additions to documentation label Sep 27, 2023
@Okabe-Junya
Copy link
Contributor

This PR seems to have been left unattended. I can take over if needed. In that case, I'll make sure the contribution is appropriately credited.

What do you think?

@zkoppert
Copy link
Member

Yeah @Okabe-Junya feel free to continue with this one.

zkoppert added a commit that referenced this pull request Oct 12, 2023
@zkoppert zkoppert closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants