fix: #161 Incorrect output values in issue_metrics.json #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify write_to_json() to take the value from the "avg" element of the dict, since the dict is passed to write_to_json(). Also change the type of the write_to_markdown argument to dict.
This was referenced Nov 1, 2023
zkoppert
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Thanks for the fix @eichisanden! Sorry that this broke for the json output and I'm glad that you contributed a fix! I'll also head over to your other PR for med and p90 to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For the moment,
medand90pare not supported, but the bug whereavgis not output correctly has been addressed.Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
bug,documentation,enhancement,infrastructure, orbreaking