Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pages-gem.yml #34

Merged
merged 3 commits into from Jan 11, 2024
Merged

Create pages-gem.yml #34

merged 3 commits into from Jan 11, 2024

Conversation

tsusdere
Copy link
Contributor

@tsusdere tsusdere commented Jan 2, 2024

Adds workflow to automate publishing the gem to RubyGems

@tsusdere tsusdere marked this pull request as ready for review January 2, 2024 22:02
@tsusdere tsusdere requested a review from a team as a code owner January 2, 2024 22:02
@tsusdere tsusdere merged commit 510cdf1 into master Jan 11, 2024
6 checks passed
@tsusdere tsusdere deleted the publish-gem branch January 11, 2024 18:04
Copy link

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsusdere Sorry for stupid questions, but unless I'm missing something this wasn't adapted when copied over from github/pages-gem:

Comment on lines +19 to +22
gem build github-pages.gemspec
- name: Publish
run: |
gem push github-pages.gem --key ${{ secrets.PAGES_GEM_PUBLISH }}
Copy link

@janbrasna janbrasna Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Does a release here in jekyll-commonmark-ghpages warrant publishing github-pages?

  2. Since there's no github-pages.gemspec here, only jekyll-commonmark-ghpages.gemspec, won't this fail? (Maybe I'm horribly missing something, sorry if that's the case…)

  3. Bonus question, since the resulting gem has a version in its filename, you won't have package-name.gem but e. g. package-name-0.4.0.gem to push. Won't you need some more output magic to push the correct filename? — ah yea this: Fix release script pages-gem#903 + Another publish script fix pages-gem#904

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out that yeah this workflow will not work as is 😁. Will fix it when I get a chance for next release (we copied it in lots of repos actually!).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/starter-workflows has a neat trick ci/gem-push.yml#L39-L48 if you don't want to manage gem file names in every repo separately… simply wildcarding it everywhere;)

Suggested change
gem build github-pages.gemspec
- name: Publish
run: |
gem push github-pages.gem --key ${{ secrets.PAGES_GEM_PUBLISH }}
gem build *.gemspec
- name: Publish
run: |
gem push *.gem --key ${{ secrets.PAGES_GEM_PUBLISH }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants