New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Add janet to list of github languages #146
Comments
Simply to use clojure syntax highlighting on GitHub for Janet files - makes things look nice. It would be great to contribute a grammar to linguist, but I’m not sure janet quite meets the requirements for a language to be included in linguist (although they are quite inclusive, so maybe they will). See https://github.com/janet-lang/janet/blob/master/.gitattributes |
Neat, I didn't know about that - very nice. |
Preface: I'm commenting as a casual observer, not a Linguist contributor. The Linguist guideline says "In most cases we prefer that each new file extension be in use in hundreds of repositories before supporting them in Linguist."
As of today, GitHub search shows 247 code results for .janet files. This 247 number indicates files. There appears to be no way to view code extensions by repository, so these code results would need a few hundred more to show the likelihood of "hundreds of repositories." That said, there are precedents with <2k code results (example: MLIR grammar in pull request #4610) and Janet repositories can remain very small, ~2 .janet files for a complete project (project.janet and a source file). Further, 800+ stars on Janet supports evidence of a growing community. Looking at recent Linguist pull requests, a successful Janet addition appears likely. |
Well, seems unlikely in the near future. At least we tried 🤷♂️ |
Closing for now, may reopen if the issue is relevant again (more traction on GitHub). |
https://github.com/github/linguist/blob/master/CONTRIBUTING.md
It would be nice if projects using janet / .janet files showed up in the metric bar on github.
Also - this repo shows clojure in use in the metric bar - I wonder why?
The text was updated successfully, but these errors were encountered: