Add Apache thrift support to generated? check #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Could this be limited to only files with a certain extension like we did in the other methods? |
|
@pchaigno Good idea, added |
| return false unless ['.rb', '.py', '.go', '.js', '.m', '.java', '.h', '.cc', '.cpp'].include?(extname) | ||
| return false unless lines.count > 1 | ||
|
|
||
| return lines[0].include?("Autogenerated by Thrift Compiler") || lines[1].include?("Autogenerated by Thrift Compiler") |
There was a problem hiding this comment.
Not sure which would be faster. I find the the current implementation more readable.
There was a problem hiding this comment.
Yep, let's keep the current one (I was kind of hoping for a better way to write it in Ruby...).
|
👍 thanks for this @vighnesh1987. This should be live on GitHub with the next release of Linguist. |
arfon
added a commit
that referenced
this pull request
May 20, 2015
Add Apache thrift support to generated? check
|
Awesome! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache Thrift compiler generated files are currently ignored in the
generated?check leading to massive PRs which are hard to parse. This commit fixes the same.