-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't count VCL as Perl for statistics. #3857
Don't count VCL as Perl for statistics. #3857
Conversation
While the Varnish-specific language was apparently inspired by C and Perl, there's no reason to group it as Perl for repo statistics.
I could also see setting the group as "Other" or "Vendor-Specific"/"Domain-Specific" if these kinds of languages should be grouped together, but that doesn't seem to be a pattern in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. From the language's documentation, the relation to Perl is superficial at best. It's definitely not Perl syntax, either.
@gjtorikian added the Perl group to VCL in #2298. Could be an oversight or he had some legitimate reason. @gjtorikian Do you remember? |
Oh, it was almost certainly an oversight. In fact, I’m a bit embarrassed to see that I deleted the color, too. 😨 It might be nice to define that back in here again. |
I can make that color change too as part of this PR. |
The colour deletion was justified if VCL was grouped under Perl, because it would never have had a chance to be used or seen in the language bar. Nothing to feel embarrassed about. =) |
Which was accidentally removed as part of https://github.com/github/linguist/pull/2298/files#diff-3552b1a64ad2071983c4d91349075c75L3223
Thanks @Alhadis and @gjtorikian for your work on this project and feedback on this PR! VCL's |
Thanks! |
While the Varnish-specific language was apparently inspired by C and Perl, there's no reason to group it as Perl for repo statistics. Also re-adding the VCL
color
definition.