Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist injectionSelector in grammars #4032

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

pchaigno
Copy link
Contributor

injectionSelector is an (undocumented?) key for Atom. See cdibbs/language-jison#17 for details.

/cc @vmg

Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. I've written many grammars that make use of this property, because the syntax of TextMate's "normal" injection selectors is frigging impossible to figure out. 👍

@pchaigno
Copy link
Contributor Author

@Alhadis Do you know if it's documented anywhere?

@Alhadis
Copy link
Collaborator

Alhadis commented Feb 13, 2018

Nowhere officially, no. But there are wayyy too many parts of the TextMate grammar system that suffer from sketchy documentation. 😕

For example, there's also a little known property called matchEndFirst that (too my knowledge) has only ever been used by the original Perl grammar. It's never been documented anywhere.

@vmg vmg merged commit 04e7956 into github-linguist:master Feb 13, 2018
@pchaigno pchaigno deleted the whitelist-injectionSelector branch February 13, 2018 12:07
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants