Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the CUE language & Cue Sheet #5312

Merged
merged 7 commits into from
Apr 16, 2021
Merged

Add support for the CUE language & Cue Sheet #5312

merged 7 commits into from
Apr 16, 2021

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Apr 6, 2021

This PR adds support for the CUE language.

Description

Checklist:


TODO

  • Add "Cue Sheet" language support

@zchee zchee requested a review from a team as a code owner April 6, 2021 23:00
@zchee
Copy link
Contributor Author

zchee commented Apr 6, 2021

/cc @mpvl @myitcv

@myitcv
Copy link

myitcv commented Apr 7, 2021

@zchee wonderful!

Cross referencing #5013

@lildude any pointers/additional things we should consider as part of this PR?

@Alhadis Alhadis changed the title feat(grammar,languages): add support for CUE language Add support for the CUE language Apr 7, 2021
@lildude
Copy link
Member

lildude commented Apr 7, 2021

@lildude any pointers/additional things we should consider as part of this PR?

Yes... #5013 (comment)

@zchee
Copy link
Contributor Author

zchee commented Apr 7, 2021

@lildude
Copy link
Member

lildude commented Apr 8, 2021

What we will need is for cue sheet to be added as part of this PR too so this PR will then implement the two most prominent languages that currently use the .cue extension on GitHub.

I don't think a heuristic will be needed as the two languages are quite distinct so the classifier should be able to differentiate between the two. Adding two good samples of each would certainly help.

So to put it into points of things to do in this PR:

  • Add support for "Cue Sheet" as a new data language
  • Add two cue sheet samples
  • Add another CUE sample

@lildude lildude mentioned this pull request Apr 8, 2021
5 tasks
@zchee
Copy link
Contributor Author

zchee commented Apr 8, 2021

@lildude thanks for very details reply. and I understand all.

Adding two good samples of each would certainly help.

also got it.

will do and mention to you after done.


However, I have one question about "cue sheet" side.

Add support for "Cue Sheet" as a new data language

I didn't googling yet, but if there is no highlighting metadata for "cue sheet", what should I do? write tm file even I don't know "cue sheet" syntax...?

@zchee
Copy link
Contributor Author

zchee commented Apr 12, 2021

@lildude added Cue Sheet language support. PTAL.

@zchee
Copy link
Contributor Author

zchee commented Apr 12, 2021

@lildude sorry, fixed CI error. PTAL again.

@lildude lildude changed the title Add support for the CUE language Add support for the CUE language & Cue Sheet Apr 13, 2021
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the Cue Sheet support.

Can you please rename it to use titlecase as I've commented inline. You'll need to rename the directory holding the samples too.

Can you please also update the template to link to the source of all four of the samples in this PR and state the license for each file.

🙇

lib/linguist/languages.yml Outdated Show resolved Hide resolved
vendor/README.md Outdated Show resolved Hide resolved
@zchee
Copy link
Contributor Author

zchee commented Apr 15, 2021

@lildude thanks, will fix

@zchee
Copy link
Contributor Author

zchee commented Apr 15, 2021

@lildude PTAL.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 Thanks @zchee.

You've just missed the last release so GitHub.com won't gain support until the next release is made which will be in about a month's time.

@lildude lildude merged commit cb6e6b6 into github-linguist:master Apr 16, 2021
@zchee
Copy link
Contributor Author

zchee commented Apr 16, 2021

@lildude Thanks a lot!

@lildude lildude mentioned this pull request Apr 16, 2021
4 tasks
@zchee zchee deleted the cue branch April 16, 2021 15:38
kalkin added a commit to kalkin/file-expert that referenced this pull request Sep 19, 2021
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants