-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the CUE language & Cue Sheet #5312
Conversation
Yes... #5013 (comment) |
@lildude ah, What should I do? edit https://github.com/github/linguist/blob/master/lib/linguist/heuristics.yml ...? |
What we will need is for cue sheet to be added as part of this PR too so this PR will then implement the two most prominent languages that currently use the I don't think a heuristic will be needed as the two languages are quite distinct so the classifier should be able to differentiate between the two. Adding two good samples of each would certainly help. So to put it into points of things to do in this PR:
|
@lildude thanks for very details reply. and I understand all.
also got it. will do and mention to you after done. However, I have one question about "cue sheet" side.
I didn't googling yet, but if there is no highlighting metadata for "cue sheet", what should I do? write tm file even I don't know "cue sheet" syntax...? |
@lildude added Cue Sheet language support. PTAL. |
@lildude sorry, fixed CI error. PTAL again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the Cue Sheet support.
Can you please rename it to use titlecase as I've commented inline. You'll need to rename the directory holding the samples too.
Can you please also update the template to link to the source of all four of the samples in this PR and state the license for each file.
🙇
@lildude thanks, will fix |
Co-authored-by: Colin Seymour <colin@github.com>
Co-authored-by: Colin Seymour <colin@github.com>
@lildude PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 Thanks @zchee.
You've just missed the last release so GitHub.com won't gain support until the next release is made which will be in about a month's time.
@lildude Thanks a lot! |
This PR adds support for the CUE language.
Description
Checklist:
TODO