Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exceptions to be configured #27

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Dec 27, 2022

In some projects, the defaults we have configured for the no-generic-link-text rule do not make sense. We should allow exceptions to be configured.

With this update, exceptions can be configured for the no-generic-link-text rule like so:

"no-generic-link-text": { "exceptions": ["link"] } 

In particular, this need surfaced in the Primer ViewComponents repo, where we don't want to flag [Link](primer.style/view_components/components/link) where Link refers to a component, rather than a generic text. We determined that allowing exceptions is the better route to go for now.

@khiga8 khiga8 marked this pull request as ready for review December 27, 2022 16:58
@khiga8 khiga8 requested a review from a team as a code owner December 27, 2022 16:58
@accessibility-bot
Copy link
Collaborator

👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos (with description following) demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

@khiga8 khiga8 merged commit 207b296 into main Dec 27, 2022
@khiga8 khiga8 deleted the kh-allow-specify-exceptions branch December 27, 2022 18:11
@khiga8
Copy link
Contributor Author

khiga8 commented Dec 27, 2022

Since nearly everyone in my team is OOO and this was reviewed by Jon, I merged this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants