Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image in heading worked yesterday; doesn't work today #1010

Closed
belltown opened this issue Mar 14, 2017 · 4 comments
Closed

Image in heading worked yesterday; doesn't work today #1010

belltown opened this issue Mar 14, 2017 · 4 comments

Comments

@belltown
Copy link

Up until this morning, my README.md file displayed an image inside an h1 tag.

It used to look something like this:

VioletBug — Roku Debugger Graphical Interface

Now, it looks like this:

![](https://raw.githubusercontent.com/belltown/violetbug/master/doc/icon.png) VioletBug — Roku Debugger Graphical Interface

Here's the start of my README.md file:

 <h1 style="color: white; background-color: #af9cd9; padding: 2em 0; text-align: center">![](https://raw.githubusercontent.com/belltown/violetbug/master/doc/icon.png) VioletBug — Roku Debugger Graphical Interface</h1>

---

Has something changed in how GitHib parses markdown files?

@Tetr4
Copy link

Tetr4 commented Mar 15, 2017

Somethings seems to have changed regarding the parsing of markdown mixed with html.
This code used to render fine:

<p></p>
[Link1](github.com)  
[Link2](github.com)  

but now it renders as:

[Link1](github.com) [Link2](github.com)

@raine
Copy link

raine commented Mar 15, 2017

Not the same issue specifically, but I also noticed some changes.

-- no longer renders as a thin line, and backtick formatted links are broken in tables as seen here: https://github.com/raine/ramda-cli#functions

@shawnajean
Copy link
Member

Hi all! We updated our markdown renderer for blobs to CommonMark yesterday:

https://github.com/blog/2333-a-formal-spec-for-github-flavored-markdown

CommonMark requires that there be a new line between HTML and markdown syntax, so that's the reason for this change.

We do not consider this a bug, so I'm going to close this out. If you have other questions about this transition or other markdown formatting issues, please reach out to our support team.

Tetr4 pushed a commit to Tetr4/arden2bytecode that referenced this issue Mar 15, 2017
GitHubs markdown renderer was changed to CommonMark, which requires that there be a new line between HTML and markdown syntax. See github/markup#1010 (comment)
and https://githubengineering.com/a-formal-spec-for-github-markdown/
@belltown
Copy link
Author

The change broke my tables as well. I had tables with empty headings which used to render as tables on all Markdown parsers, including GitHub's. Now I have to put something in the table headers (a single space character works).

tanoargie added a commit to tanoargie/tanoargie that referenced this issue Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants