Markdown tables with 2 character dashes under headers do not render as tables

[kendaleiv]

Id	Name
1	Test

does not render as a table, whereas

Id	Name
1	Test

does.

Is this expected behavior?

[pchaigno]

Why would you want to use only 2?

[kendaleiv]

Using the same number of characters as the header to create the divider, in this case, Id.

[pchaigno]

As long as you put as least 3 dashes, the table will always look the same.

| Id | Name |
| ----------------- | ---- |
| 1 | Test |

render as

Id	Name
1	Test

[kendaleiv]

Yes, but I am raising the issue that GitHub users could construct tables in terms of my first example, and that is not displayed as an HTML table.

[pchaigno]

Oh. I see.
Redcarpet renders the Markdown. You should maybe post an issue on their repository.

[kendaleiv]

OK, thanks! Created vmg/redcarpet#418.

[gjtorikian]

Redcarpet does not render our Markdown. We use an internal closed-source gem, github-markdown.

However, the three dashes are expected behavior.

[kendaleiv]

Are the three dashes required, and two is simply invalid?

[pchaigno]

Oh my bad. The README.md is a bit confusing:

The following markups are supported. The dependencies listed are required if you wish to run the library. You can also run script/bootstrap to fetch them all.
.markdown, .mdown, .mkdn, .md -- gem install redcarpet (https://github.com/vmg/redcarpet)

I assumed RedCarpet was rendering the Markdown without really checking the code :/

[kendaleiv]

Reopening in light of new information from @gjtorikian.

[mojavelinux]

Redcarpet does not render our Markdown. We use an internal closed-source gem, github-markdown.

That's the interface gem, but underneath it still uses an actual Markdown implementation. It's not clear from the code which implementation that is, but my understanding is that it's Redcarpet.

https://github.com/github/markup/blob/master/lib/github/markup/markdown.rb

[gjtorikian]

And we walk through all the Markdown implementations available to stop at the one that loads first: https://github.com/github/markup/blob/master/lib/github/markup/markdown.rb#L33-L39

Are the three dashes required, and two is simply invalid?

Three (or more) dashes, yes.

[kendaleiv]

This is a minor issue -- but supporting the two character use case (and, maybe a single char as well) would be a nice touch for GitHub users. I ran into this during my workday today.

[bkeepers]

Thanks for the request. I've logged it with our internal teams.

[kendaleiv]

Thanks! 🍰

[greenlaw110]

not sure why the following table doesn't work:

The source code:

 | URL    | Accept | Effective URL |
 | ------ | ------ | ------------- |
 | `/csv` | `text/csv` |  `/`  |
 | `/json` | `application/json` | `/` |
 | `/xls` | `application/vnd.ms-excel` | `/` |
 | `/xlsx` | `application/vnd.openxmlformats-officedocument.spreadsheetml.sheet` | `/` |

It doesn't render as a table:

URL	Accept	Effective URL
/csv	text/csv	/
/json	application/json	/
/xls	application/vnd.ms-excel	/
/xlsx	application/vnd.openxmlformats-officedocument.spreadsheetml.sheet	/

[pchaigno]

@greenlaw110 You need to remove the single space before each line.

[greenlaw110]

@pchaigno yes I just noticed that :-)