Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Asciidoctor 1.5.6.1 #1088

Merged
merged 1 commit into from
Jul 25, 2017

Conversation

miltador
Copy link
Contributor

@miltador miltador commented Jul 18, 2017

New patch version has been released.
Change log available here:
https://github.com/asciidoctor/asciidoctor/blob/master/CHANGELOG.adoc#156-2017-07-12---mojavelinux

@mojavelinux
Copy link
Contributor

I'll be releasing 1.5.6.1 on July 19. We should use that instead as it addresses a few regressions that 1.5.6 introduced.

@miltador
Copy link
Contributor Author

Oh, great, thanks. Then I will close this.

@miltador miltador closed this Jul 18, 2017
@mojavelinux
Copy link
Contributor

I don't think you have to close. Just update the title.

@miltador miltador reopened this Jul 18, 2017
@kivikakk
Copy link
Contributor

@mojavelinux If you can drop a ping on this issue when 1.5.6.1 lands, I'll happily update this PR, merge and release!

@mojavelinux
Copy link
Contributor

Thanks @kivikakk! You're the best. I'll let you know asap.

@mojavelinux
Copy link
Contributor

@miltador miltador changed the title Upgrade to Asciidoctor 1.5.6 Upgrade to Asciidoctor 1.5.6.1 Jul 24, 2017
@miltador
Copy link
Contributor Author

Updated the PR to 1.5.6.1.

@kivikakk
Copy link
Contributor

Looks good — thank you!

@kivikakk kivikakk merged commit 805e7b1 into github:master Jul 25, 2017
@kivikakk
Copy link
Contributor

github-markup 1.6.1 has been released, and is live on github.com now. Thanks so much!

@mojavelinux
Copy link
Contributor

Thank you, thank you @kivikakk for the extremely quick turnaround!

@miltador miltador deleted the asciidoctor-1.5.6 branch July 25, 2017 09:56
@mojavelinux
Copy link
Contributor

@kivikakk Do you know when this update will become available on GitHub.com? I just want to be prepared when people ask me (since they always do ;))

@kivikakk
Copy link
Contributor

@mojavelinux Ah, my bad! The updated markup gem is live, but github.com isn't running the newer Asciidoctor yet as we have our own version pinning. I'll make the transition from 1.5.5 to 1.5.6.1 there now, and let you know when it's live.

@mojavelinux
Copy link
Contributor

Thanks @kivikakk!

@kivikakk
Copy link
Contributor

kivikakk commented Aug 1, 2017

1.5.6.1 is now running on github.com! Sorry for the hold-up!

@mojavelinux
Copy link
Contributor

Thank you so much, @kivikakk! This is cause for 🍾 🎉 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants