Check whether filename is set when rendering asciidoc. Resolves #1289 #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures seem unrelated |
|
LGTM! |
|
LGTM. Test failures are indeed unrelated. |
kivikakk
approved these changes
Sep 5, 2019
|
@kivikakk It's been a while, but could you perhaps cut a bugfix release that includes the changes in this PR? Thanks! |
|
Hi @dometto — unfortunately I no longer work for GitHub and don’t have write access to the gem any more. I’m not sure who does; you may need to contact support to find out who can help with this now. |
|
@Alhadis ping... I see that you seem to have picked up the torch recently. Any chance of doing a bug fix release? |
medsauce
approved these changes
Dec 20, 2020
medsauce
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used @mojavelinux's snippet from issue #1289, but also added a test for good measure.