Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newline inside SVG image references #1368

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/github/commands/rest2html
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,11 @@ class GitHubHTMLTranslator(HTMLTranslator):
else:
atts[attribute] = value

# inside references, SVG images must not add a newline,
# the default suffix for starttag method
if node.parent.tagname == "reference":
atts["suffix"] = ""

# toss off `object` tag
self.body.pop()
# add on `img` with attributes
Expand Down