Skip to content
This repository has been archived by the owner on Sep 3, 2019. It is now read-only.

Commit

Permalink
Remove a bunch of extraneous ** from patterns in etc/gitignore
Browse files Browse the repository at this point in the history
These were added in ef3e533, but they
are hurting, not helping. Consider the following patterns:

foo/
**/foo/
foo/**

The first will match all directories named "foo" (and anything inside
them) no matter where they reside in the repository.

The second will match directories named "foo" (and anything inside
them), but only if they are below the .gitignore in the directory
structure.

The third will match anything inside all directories named "foo".

Because Git only tracks files, not directories, the first and third
patterns are essentially equivalent. Since the first is simpler, we
should prefer it.

The second pattern can be useful in some cases, but as far as I can tell
it is not actually desired in any of the cases where we are currently
using it.

So, I've replaced all instances of patterns 2 and 3 above with pattern
1.
  • Loading branch information
aroben committed Jun 11, 2012
1 parent d0afcf3 commit efcb0fe
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions etc/gitignore
@@ -1,14 +1,12 @@

################# #################
## Eclipse ## Eclipse
################# #################


*.pydevproject *.pydevproject
.project .project
.metadata .metadata
bin/** bin/
tmp/** tmp/
tmp/**/*
*.tmp *.tmp
*.bak *.bak
*.swp *.swp
Expand Down Expand Up @@ -44,8 +42,8 @@ local.properties
*.sln.docstates *.sln.docstates


# Build results # Build results
**/[Dd]ebug/ [Dd]ebug/
**/[Rr]elease/ [Rr]elease/
*_i.c *_i.c
*_p.c *_p.c
*.ilk *.ilk
Expand All @@ -63,10 +61,10 @@ local.properties
*.tmp *.tmp
*.vspscc *.vspscc
.builds .builds
**/*.dotCover *.dotCover


## TODO: If you have NuGet Package Restore enabled, uncomment this ## TODO: If you have NuGet Package Restore enabled, uncomment this
#**/packages/ #packages/


# Visual C++ cache files # Visual C++ cache files
ipch/ ipch/
Expand Down

0 comments on commit efcb0fe

Please sign in to comment.