-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
puppet5 #135
puppet5 #135
Conversation
Hey @mschuchard - curious what you think about this one. Will the effective change of ReferenceValidationError to CatalogError in Puppet 5 cause problems with your integration? Would it be worthwhile to change the exception type for Puppet 3 and 4 to CatalogError for consistency, and get rid of ReferenceValidationError entirely? |
@kpaulisse Thanks for the heads up! I understand the concept that APIs are a moving target, so don't worry about if anything breaks on my end for these changes. Since it appears you are going full on TDD for this and the tests are finished with the code to come, I can read through the code when it changes. What I find interesting are the conditional dependencies in the I also got lucky and Puppet 5 seemed to change nothing with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it a deep dive; thanks!
Updates to support puppet 5.