Add support for puppetdb behind basic auth

[ahayworth]

Overview

This pull request adds basic auth support for puppetdb URLs.

We have a moderately unique puppet setup (though remarkably close to
github's setup, in some ways). We run puppetdb behind a proxy that is
secured with basic auth (and we will eventually be submitting patches
upstream to puppet). This commit allows octocatalog-diff to parse a basic
auth username, and password from a URL.

Checklist

• [✓] Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
• [✓] Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
• [✓] If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended. (n/a)
• [✓] If you have added any new gem dependencies, make sure those gems are licensed under the MIT or Apache 2.0 license. We cannot add any dependencies on gems licensed under GPL. (n/a)
• [✓] If you have added any new gem dependencies, make sure you've checked in a copy of the .gem file into the vendor/cache directory. (n/a)

[ahayworth]

It should be noted that many specs fail unless you have v 1.15.4 of bundler installed - which seems to be why CI is failing. rake passes all tests locally with 1.15.4 installed.

[kpaulisse]

Hey @ahayworth thanks for submitting a PR for this feature. It's been a while since the CI suite ran, and it looks like there were some changes to the bundler version at Travis that broke things. I've just merged a fix, so hopefully if you pull the latest master into your branch it'll pass 🤞 .

[ahayworth]

Heyo -

Thanks for that! Looks like it's failing under some ruby versions I'm not running locally, so I'll get those, re-test, and update later. :)

[ahayworth]

Looks like the build failure was ~transient, at least to me. Re-build looks okay.

[kpaulisse]

Looks like the build failure was ~transient, at least to me

😿 I have also seen some flaky tests - currently investigating improvements because that can be super frustrating. Thanks for your persistence!

[ahayworth]

No problem, my pleasure! - Andrew Hayworth

…

On Nov 15, 2017, at 3:48 PM, Kevin Paulisse ***@***.***> wrote: Looks like the build failure was ~transient, at least to me 😿 I have also seen some flaky tests - currently investigating improvements because that can be super frustrating. Thanks for your persistence! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[kpaulisse]

Being tested internally within GitHub. Will merge soon.

Thanks again!