Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppet version check environment #16

Merged
merged 3 commits into from
Nov 7, 2016

Conversation

kpaulisse
Copy link
Contributor

@kpaulisse kpaulisse commented Nov 3, 2016

Overview

This pull request runs the puppet command in a cleaned environment for puppet --version too. Not doing this causes (in some configurations) problems such as #8.

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.

Fixes #8
Fixes #14

@kpaulisse kpaulisse mentioned this pull request Nov 7, 2016
@kpaulisse kpaulisse merged commit e2909b2 into master Nov 7, 2016
@kpaulisse kpaulisse deleted the kpaulisse-puppet-version-check-environment branch December 30, 2016 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puppet version check doesn't sanitize the environment Unable to determine Puppet version
1 participant