Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PE RBAC token use with PuppetDB #169

Merged
merged 2 commits into from
Dec 19, 2017

Conversation

JohnLyman
Copy link

Overview

This pull request adds the ability to use a PE RBAC token with PuppetDB.

Closes #156

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended.
  • If you have added any new gem dependencies, make sure those gems are licensed under the MIT or Apache 2.0 license. We cannot add any dependencies on gems licensed under GPL.
  • If you have added any new gem dependencies, make sure you've checked in a copy of the .gem file into the vendor/cache directory.

@kpaulisse
Copy link
Contributor

Hey @JohnLyman !

Thanks for the contribution of PE token authentication for PuppetDB. The code looks good to me, so I'm going to run this through our normal release process (a couple days of internal testing in our Puppet install within GitHub) and then push it out as a new minor release.

🎉

@kpaulisse kpaulisse self-requested a review December 16, 2017 04:59
@JohnLyman
Copy link
Author

Great, thanks!

@kpaulisse kpaulisse mentioned this pull request Dec 17, 2017
Copy link
Contributor

@kpaulisse kpaulisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge as part of #172. Thank you for your contribution!

@kpaulisse kpaulisse merged commit d0d6615 into github:master Dec 19, 2017
@kpaulisse
Copy link
Contributor

Hey @JohnLyman - this is all merged, thanks!

The e-mail address from your commit isn't associated with your GitHub account. If you associate that address, you'll show up in https://github.com/github/octocatalog-diff/graphs/contributors next time we update master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to use pe-token for puppetdb fact retrieval
2 participants