Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance CompilationDir to filter out cases outlined in #187 & #188 #190

Merged
merged 2 commits into from
Dec 9, 2018
Merged

Enhance CompilationDir to filter out cases outlined in #187 & #188 #190

merged 2 commits into from
Dec 9, 2018

Commits on Jun 6, 2018

  1. Fix github#187,github#188 CompilationDir not supporting complex or mu… 

    …ltiple values

There were two cases where CompilationDir wasn't filtering out changes:
* if the parameter value is an arbitrary data structure (ie hash, array
or mix of both)
* if the parameter value is a string containing more than one occurence
of the compilation dir

It turns out that both can be fixed by just replacing the compilation
dirs in both the new and old values with empty strings and comparing
what's left.

It's probably much slower than the original string-only implementation
but covers much more cases as demonstrated by github#187 and github#188.
    Brice Figureau committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    697cbb9 View commit details
    Browse the repository at this point in the history

  2. Fix some minor typo in the diff object documentation 

    I noticed a few mistakes while reading the API documentation, and I
couldn't resist to fix them.
    Brice Figureau committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    f1039dc View commit details
    Browse the repository at this point in the history