-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use modulepath from environment.conf if available #20
Conversation
Hi @kpaulisse , switched to the branch and ran the job again without the symlinks, seems mostly ok. I did get a few new warnings that might need attention : Previous output of this job : I, [2016-11-09T07:17:33.832042 #91999] INFO -- : Catalogs compiled for [REDACTED] Package[tcpdump] => New output on the branch : W, [2016-11-09T07:20:39.047633 #93417] WARN -- : WARNING: Hiera datadir for yaml doesn't seem to exist at /var/folders/6n/8xsv9cv56h3d6pg5mfx5gx1c0000gr/T/d20161109-93417-cnatq4environments/production/hieradata Package[tcpdump] => Thanks for your work on this! |
There seems to be a missing Are you using e.g.
|
Yes that was it. Thanks. |
Overview
This pull request checks
environment.conf
(if available) and uses the modulepath to inform its lookup locations for the--compare-file-text
option.Fixes #12
Checklist
rake
in your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:spec
or ignoring untestable sections of code with# :nocov
comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests./cc @eelcomaljaars who originally reported the problem. Can you see if this code fixes the problem without your symlink workaround?