Add 'name' parameter to the 'resource_hash' for validate_references #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request changes the
Catalog validation
functionality.The
Apache
httpd server is well known to be THE software that has different names between RHEL based OS (httpd
) and Debian + others ones (apache2
).For this kind of issue, Puppet allows you to add an
alias
parameter on any resource and this works fine inoctocatalog-diff
.The Apache module we use (
puppetlabs-apache
, "version": "2.3.0") defines thename
parameter and not thealias
. Then the catalog validation fails in our case (puppetlabs-apache
+voxpupuli/puppet-puppetboard:4.0.0
)To work around this limitation, I added the
name
parameter to theresources_hash
object if it exists.Checklist
rake
in your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:spec
or ignoring untestable sections of code with# :nocov
comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests./cc [related issues] [teams and individuals, making sure to mention why you're CC-ing them]