Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set quality comparison to ignore filter #230

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

seanmil
Copy link
Contributor

@seanmil seanmil commented Dec 14, 2020

Overview

This pull request introduces new functionality to the --ignore option, allowing array values to parameters to be ignored if they have set equality.

Resources may accept array parameters but may not change behavior depending on the order of those parameters. In those situations it would be good to be able to ignore changes due only to array ordering.

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended.
  • If you have added any new gem dependencies, make sure those gems are licensed under the MIT or Apache 2.0 license. We cannot add any dependencies on gems licensed under GPL.
  • If you have added any new gem dependencies, make sure you've checked in a copy of the .gem file into the vendor/cache directory.

seanmil and others added 2 commits December 12, 2020 07:32
Add new syntax for supporting set equality checks for parameters
with arrays of values where order is not important.
Copy link
Contributor

@ahayworth ahayworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 😄

@ahayworth ahayworth merged commit 58b3fb7 into github:master Dec 15, 2020
@ahayworth ahayworth added this to the 2.0.0 milestone Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants