Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes typos in starting-a-project.md of Japanese translation. #1424

Merged
merged 2 commits into from Feb 21, 2020
Merged

Fixes typos in starting-a-project.md of Japanese translation. #1424

merged 2 commits into from Feb 21, 2020

Conversation

s4na
Copy link
Contributor

@s4na s4na commented Feb 21, 2020 •
edited

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

I found some typos in Japanese translation, and try to fix them.馃槉

Best regards,
s4na

@s4na s4na marked this pull request as ready for review February 21, 2020 09:09
yuichielectric
yuichielectric approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@yuichielectric yuichielectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix 馃挴 Thanks!

@yuichielectric yuichielectric merged commit c4bcae5 into github:master Feb 21, 2020
@vincyyou
Copy link

T

1 similar comment
@vincyyou
Copy link

T

@github github locked as spam and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuichielectric yuichielectric yuichielectric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@s4na @vincyyou @yuichielectric