Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo "有効的" -> "友好的" in Japanese #3028

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fix typo "有効的" -> "友好的" in Japanese #3028

merged 1 commit into from
Jun 16, 2023

Conversation

igrep
Copy link
Contributor

@igrep igrep commented Jun 10, 2023

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@igrep igrep requested a review from a team as a code owner June 10, 2023 01:36
ahpook
ahpook approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with google translate; it says this changes the sentence from "If the project is neither effective nor welcoming" to "... not friendly or welcoming".

@ahpook
Copy link
Contributor

ahpook commented Jun 16, 2023

Thank you for the improvement!

@ahpook ahpook added this pull request to the merge queue Jun 16, 2023
Merged via the queue into github:main with commit b357dda Jun 16, 2023
1 check passed
@igrep igrep deleted the patch-1 branch June 16, 2023 22:56
@igrep
Copy link
Contributor Author

igrep commented Jun 16, 2023

Confirmed with google translate; it says this changes the sentence from "If the project is neither effective nor welcoming" to "... not friendly or welcoming".

That's right! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahpook ahpook ahpook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@igrep @ahpook