Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[korean translation] translate sentences more naturally and translate wise saying #3029

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

penrose15
Copy link
Contributor

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


I found that some sentences in translation at _article/ko/how-to-contribute.md is awkward.
so I translate the sentences

Before

이전에 오픈소스에 기여한 적이 없다면, 케네디 미국 전 대통령으로부터 조언을 구하세요. "Ask not what your country can do for you - ask what you can do for your country."

After

이전에 오픈 소스에 기여한 적이 없다면, 미국 존 케네디 대통령의 명언을 떠올려보세요.
"Ask not what your country can do for you - ask what you can do for your country."
"국가가 나를 위해 무엇을 해줄 것을 바라기에 앞서, 내가 국가를 위해 무엇을 할 것인가를 생각해야 한다."

@penrose15 penrose15 requested a review from a team as a code owner June 13, 2023 13:59
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this change with google translate.

@ahpook
Copy link
Contributor

ahpook commented Jun 16, 2023

@penrose15 thank you for the contribution!

@ahpook ahpook added this pull request to the merge queue Jun 16, 2023
Merged via the queue into github:main with commit aa56727 Jun 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants