Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create #3209

Merged
merged 33 commits into from
Apr 30, 2024
Merged

Create #3209

merged 33 commits into from
Apr 30, 2024

Conversation

BlueButterflies
Copy link
Contributor

Greetings,
I followed the instructions as written in the instructions to be able to contribute to the translation.
I decided to contribute to the translation of the project into the Bulgarian language, so people who don't know any languages other than Bulgarian can read your valuable advice on collaborating on open source projects.

Thank you in advance

@BlueButterflies
Copy link
Contributor Author

Hi I don't understand why every time doing pull request it fails in the test part?

…-for-open-source-maintainers.md,metrics.md, starting-a-project.md. And with this I finished translating everything
@BlueButterflies
Copy link
Contributor Author

Hi , I finished translating everything. I ask to be checked and approved. Thank you in advance.

@BlueButterflies
Copy link
Contributor Author

BlueButterflies commented Mar 27, 2024

I don't understand, because I need to git revert and --no-gpg-sign?

@ipc103
Copy link
Contributor

ipc103 commented Mar 27, 2024

I don't understand, because I need to git revert and --no-gpg-sign?

Hi @BlueButterflies - you can ignore those comments as spam. Thank you for your contribution ❤️ Someone from our core team will review your contribution shortly and let you know if we have feedback. Thanks!

@BlueButterflies
Copy link
Contributor Author

I don't understand, because I need to git revert and --no-gpg-sign?

Hi @BlueButterflies - you can ignore those comments as spam. Thank you for your contribution ❤️ Someone from our core team will review your contribution shortly and let you know if we have feedback. Thanks!

Thank you

Copy link

@YahyaMohamedYahya YahyaMohamedYahya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BlueButterflies thank you so much for the translation. ❤️ I have a few questions.

.vs/opensource.guide/v17/DocumentLayout.json Outdated Show resolved Hide resolved
.vs/VSWorkspaceState.json Outdated Show resolved Hide resolved
.vs/VSWorkspaceState.json Outdated Show resolved Hide resolved
@MarwanBz
Copy link

Hey @BlueButterflies have you figured out what caused the GitHub Actions CI / tests to failed?

@BlueButterflies
Copy link
Contributor Author

BlueButterflies commented Mar 31, 2024

Hey @BlueButterflies have you figured out what caused the GitHub Actions CI / tests to failed?

@MarwanBz No . I think what error came from that I asked for revision of the code. It had happened to me for the first time and therefore I asked

@tuttheking81
Copy link

Greetings, I followed the instructions as written in the instructions to be able to contribute to the translation. I decided to contribute to the translation of the project into the Bulgarian language, so people who don't know any languages other than Bulgarian can read your valuable advice on collaborating on open source projects.

Thank you in advance

Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is what is causing the tests to fail.

Added space that was suggested to me
@BlueButterflies
Copy link
Contributor Author

BlueButterflies commented Apr 16, 2024

Hi guys, I finally managed to resolve the link connections, thanks also to your interventions.
You were helpful, especially because I didn't understand what was wrong with the links.
Thanks again.
I'm happy to have been part of the translation of the site.
I await your approval.

@github github deleted a comment Apr 16, 2024
@github github deleted a comment Apr 16, 2024
@github github deleted a comment Apr 16, 2024
@jmeridth
Copy link
Member

@BlueButterflies this looks good to me but want @ahpook to give final 👍 . Thank you for all your work and patience on this.

@BlueButterflies
Copy link
Contributor Author

@BlueButterflies this looks good to me but want @ahpook to give final 👍 . Thank you for all your work and patience on this.

Thank you

@github github deleted a comment from 2toa Apr 17, 2024
@BlueButterflies
Copy link
Contributor Author

@ahpook please accepts pull requests

@BlueButterflies
Copy link
Contributor Author

@BlueButterflies this looks good to me but want @ahpook to give final 👍 . Thank you for all your work and patience on this.

Hi, @jmeridth Sorry for the inconvenience, I'm wondering what to do with the pull requests in the open.guide repository in my account, since @ahpook linked everything to me. Because then I should make pull requests to the open-giude repository owned by github.
I hope I explained myself well. Thank you in advance.

Gopstop92

This comment was marked as spam.

@jmeridth
Copy link
Member

@BlueButterflies there may be a bit more work needed. I'll confirm with @ahpook. Thank you again for your work and patience.

@github github deleted a comment from AlineNunes73 Apr 27, 2024
@ahpook
Copy link
Contributor

ahpook commented Apr 29, 2024

Yep this LGTM - I reran tests locally with the updated HTML-Proofer and all the internal links work. Great work @BlueButterflies , thank you for responding to all the issues.

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean checks w/html-proofer 5.0.8

@ahpook ahpook added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2024
@BlueButterflies
Copy link
Contributor Author

Clean checks w/html-proofer 5.0.8

Thank you for accepting my contribution
Sorry I ask again. in the open.guide repository in my account I have two pull requests. I merge and send to origin main with revision request and then you accept?

Thank you in advance

@ahpook
Copy link
Contributor

ahpook commented Apr 29, 2024

Oh damn, there is one more:


* At _site/bg/how-to-contribute/index.html:945:

  internally linking to #a-checklist-before-you-contribute; the file exists, but the hash 'a-checklist-before-you-contribute' does not exist

This is at line 500 in how-to-contribute.md

@ahpook
Copy link
Contributor

ahpook commented Apr 29, 2024

Sorry I ask again. in the open.guide repository in my account I have two pull requests. I merge and send to origin main with revision request and then you accept?

Sorry! I did not understand the question before.

I looked at these PRs : https://github.com/BlueButterflies/opensource.guide/pulls

They are both spam from fake accounts :( so you can just close them.

@BlueButterflies
Copy link
Contributor Author

Sorry I ask again. in the open.guide repository in my account I have two pull requests. I merge and send to origin main with revision request and then you accept?

Sorry! I did not understand the question before.

I looked at these PRs : https://github.com/BlueButterflies/opensource.guide/pulls

They are both spam from fake accounts :( so you can just close them.

Thank you

@BlueButterflies
Copy link
Contributor Author

Oh damn, there is one more:


* At _site/bg/how-to-contribute/index.html:945:

  internally linking to #a-checklist-before-you-contribute; the file exists, but the hash 'a-checklist-before-you-contribute' does not exist

This is at line 500 in how-to-contribute.md

@JhonyM20

This comment has been minimized.

Copy link
Contributor Author

@BlueButterflies BlueButterflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction of link and some untranslated sentences in the how-to-contribute file found by @ahpook

@ahpook ahpook merged commit e2327d2 into github:main Apr 30, 2024
2 of 3 checks passed
@ahpook
Copy link
Contributor

ahpook commented Apr 30, 2024

I had to fix one small thing in the data structure in #3215 but this is now live on the site!

https://opensource.guide/bg/

Thank you @BlueButterflies for all your work on this 💯

@BlueButterflies
Copy link
Contributor Author

I had to fix one small thing in the data structure in #3215 but this is now live on the site!

https://opensource.guide/bg/

Thank you @BlueButterflies for all your work on this 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
10 participants