Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct link failures that were previously hidden #3241

Merged
merged 6 commits into from
Jun 15, 2024

Conversation

ahpook
Copy link
Contributor

@ahpook ahpook commented Jun 14, 2024

These commits fix a number of link failures across the site that were previously
hidden, either because the ignore_urls pattern in html-proofer excluded their
domains, or because earlier versions of html-proofer didn't report all the errors
it found before exiting.

  • Fix 404d link to MDN workflow file

  • Update changed link for terms of service

  • Repo was renamed and the issue number lost; linking instead to the website

  • Fix typo in link to @sindresorhus/awesome

  • Translated filename crept in: CONTRIBUIRE.md should be CONTRIBUTING.md

  • Fixup stray stale link - previous regex didn't catch this one

  • Have you followed the contributing guidelines?

  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


@ahpook ahpook added this pull request to the merge queue Jun 15, 2024
Merged via the queue into main with commit 1a979b6 Jun 15, 2024
3 checks passed
@ahpook ahpook deleted the ahpook/fix-hidden-link-failures branch June 15, 2024 04:36
Copy link

@dnabookofficiaal dnabookofficiaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants