Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing write overhead of last_attempted_check #432

Merged
merged 2 commits into from
Mar 8, 2018

Conversation

shlomi-noach
Copy link
Collaborator

This PR reduces the overhead for last_attempted_check writes by postponing the write for 1sec. If instance if found by that time, write is cancelled.

It is OK that last_attempted_check turns to be slightly higher than last_checked even though this chronologically this can't be correct for a successful probe.

Write overhead is only reduced when things are generally OK. The optimization is gone away when probing instances consistently takes over 1sec.

@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=concertmaster March 7, 2018 13:49 Inactive
@sjmudd
Copy link
Collaborator

sjmudd commented Mar 8, 2018

query_load

Uploaded an image to show the difference from using an earlier version of orchestrator (3.0.1), moving to the latest code without this PR (3.0.8) and then the effect of applying the PR.

So the PR looks good and makes a huge difference in query count, possibly accentuated by the fact that I'm using some custom settings like:

 "BufferInstanceWrites": true,
  "InstanceWriteBufferSize": 500,
  "InstanceFlushIntervalMilliseconds:": 100,

@shlomi-noach
Copy link
Collaborator Author

@sjmudd we are not using same settings as you (we are using "BufferInstanceWrites": false,, and still we get similar reduction in amount of com_update:

image

@shlomi-noach
Copy link
Collaborator Author

(although we don't see a huge drop in overall query count)

@shlomi-noach shlomi-noach merged commit b9fd6ee into master Mar 8, 2018
@shlomi-noach shlomi-noach deleted the relaxing-last-attempted-check-writes branch March 8, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants