add args commandPayload for manual failover/takeover api/cmd then pass to hooks

[MOON-CLJ]

A Pull Request should be associated with an Issue.

Related issue: #955

In case this PR introduced Go code changes:

• contributed code is using same conventions as original code
• code is formatted via gofmt (please avoid goimports)
• code is built via ./build.sh
• code is tested via go test ./go/...

cc @yangeagle

[shlomi-noach]

This will only work correctly if invoked from the orchestrator cli; using the API or orchestrator-client this has no effect. Correct?
I wonder if we can make this consistent across all methods.

[MOON-CLJ]

using the API or orchestrator-client this has no effect. Correct?

yes, i know。 for orchestrator-client, not works。
orchestrator-client need one character flag for the new commandPayload args。what's your suggestion, which character one should we use? :)

"-C" ?

[MOON-CLJ]

@shlomi-noach

using the API or orchestrator-client this has no effect. Correct?

For API, i should works，see https://github.com/github/orchestrator/pull/959/files#diff-fbdc8cde28a71961e53c2e83e2483c9a

for now just orchestrator-client not works。

[MOON-CLJ]

orchestrator-client need one character flag for the new commandPayload args。what's your suggestion, which character one should we use? :)

or we can use getopt instead of getopts，but introduce some minor change of the usage 。

ignore, it's a bad idea. getopt's behavior is not consistent between macos and linux.

[MOON-CLJ]

@shlomi-noach i add -C --command-payload in orchestrator-client, pls review。

i also test in local, when "orchestrator-client .... --command-payload username:clj,a:b ....."，
i can got "ORC_COMMAND_PAYLOAD=username:clj,a:b" in environment variable。

[shlomi-noach]

Sorry about the delay; I expect to look into & merge a bunch of community PRs during the first two weeks of October.

[MOON-CLJ]

thx