Upgrade pygments.rb from 0.6.1 to 0.6.3 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a fix that'll be useful for Windows Pages users, if I'm reading it correctly. Otherwise they won't be able to use Pygments? |
Correctimundo! |
|
/cc @github/appsec Here's the diff in yajl-json: brianmario/yajl-ruby@1.1.0...1.2.0 Perhaps @brianmario or @tmm1 could also comment on the changes in the release. Overall this seems like a huge win for Windows users. Because of the numerous yajl-json changes I don't feel comfortable releasing this without a 👍 from security. The pygments.rb changes themselves seem fine. |
|
Thanks for handling this, @gjtorikian! |
|
👍 |
gjtorikian
added a commit
that referenced
this pull request
Jun 10, 2015
Upgrade pygments.rb from 0.6.1 to 0.6.3
Merged
|
YAY! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure what's happened since 0.6.1 since 0.6.1 doesn't have a tag and there are no release notes in the changelog or in the GitHub Releases. If we base it off of the commit where v0.6.0 is created (I usually do this last when working on a gem release, not sure if tmm1 is the same), then we have:
pygments/pygments.rb@f6dceb2...v0.6.3
Appears to:
yajl-rubyfrom~> 1.1.0to~> 1.2.0MENTOS_TIMEOUTenv var to be anIntegerto determine timeout for subprocessrbinstead ofrpyexecutable for WindowsFixes #144
/cc @benbalter