Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jekyll-github-metadata to 2.10.0 #611

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Conversation

mlinksva
Copy link
Contributor

@mlinksva mlinksva commented Jan 3, 2019

To get development mode https testing fix for github.com links from jekyll/github-metadata#133

To get development mode https testing fix for github.com links from jekyll/github-metadata#133
@mlinksva
Copy link
Contributor Author

mlinksva commented Jan 3, 2019

Tests failed with

$ gem install bundler
ERROR:  Error installing bundler:
	bundler requires RubyGems version >= 3.0.0. Try 'gem update --system' to update RubyGems itself.
The command "gem install bundler" failed and exited with 1 during .

I admit, I got this locally as well and couldn't work past it, hoped it was a local problem with my machine. Guess not.

This PR is not important, feel free to ignore, I'll retry eventually.

mlinksva added a commit to github/choosealicense.com that referenced this pull request Jan 3, 2019
This reverts commit bb0bb92.

Remove actual test for now, as it causes failures in CI, where github.com links get generated as http

Eventually this should be fixed with github/pages-gem#611 or similar
@parkr
Copy link
Contributor

parkr commented Jan 3, 2019

@mlinksva Hey! In the Travis configuration file, try adding “before_install: gem update —system”, and try the gem update —system command on your machine as well.

@mlinksva
Copy link
Contributor Author

mlinksva commented Jan 3, 2019

@parkr thanks, that worked.

I had tried gem update --system locally and got many instances of this while running tests:

      StandardError:
        ERROR:  Error installing bundler:
        	"bundle" from bundler conflicts with /Users/mlinksva/.rbenv/versions/2.5.3/bin/bundle

That was my "couldn't work past" above. Glad it is just a local problem! 😄

@mlinksva mlinksva merged commit 06ff297 into master Jan 3, 2019
@mlinksva mlinksva deleted the jekyll-github-metadata branch January 3, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants