Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

Escape @ symbol in yaml files #111

Merged
merged 1 commit into from Apr 1, 2019
Merged

Escape @ symbol in yaml files #111

merged 1 commit into from Apr 1, 2019

Conversation

SUPERCILEX
Copy link
Contributor

No description provided.

@aadibajpai
Copy link
Contributor

Some accounts don't have @. https://medium.com/ycombinator

@SUPERCILEX
Copy link
Contributor Author

That's a publication though, isn't the idea to showcase your profile? The problem is that the @ symbol is illegal without quotes:

found character that cannot start any token while scanning for the next token at line 30 column 11

@aadibajpai
Copy link
Contributor

Sure, but what if someone own a publication they want to showcase.

@SUPERCILEX
Copy link
Contributor Author

I disagree, but 🤷‍♂️

@SUPERCILEX SUPERCILEX changed the title Don't require @ symbol for Medium profiles Escape @ symbol in yaml files Mar 30, 2019
@aadibajpai
Copy link
Contributor

@SUPERCILEX I'm not sure either which would be the best approach. It's also possible to remove the @ and mention somewhere. I see that it works for publications when you add the @ symbol as well as without it 😃

@SUPERCILEX
Copy link
Contributor Author

So are you saying I should revert back to the first approach? I personally prefer that since it'll work for most people.

@aadibajpai
Copy link
Contributor

Yes.

@SUPERCILEX
Copy link
Contributor Author

Awesome, done!

@brandonrosage brandonrosage merged commit 5c5e90c into github:master Apr 1, 2019
@SUPERCILEX SUPERCILEX deleted the patch-1 branch April 1, 2019 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants