Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DefaultLocale by passing in undefined #22

Merged
merged 1 commit into from
May 30, 2014
Merged

Use DefaultLocale by passing in undefined #22

merged 1 commit into from
May 30, 2014

Conversation

josh
Copy link
Contributor

@josh josh commented May 30, 2014

@josh josh self-assigned this May 30, 2014
@dgraham
Copy link
Contributor

dgraham commented May 30, 2014

Interesting. I thought the locale was required to get the date and time formats correct. But the locale is only used to detect the language the text appears in, not the formatting.

I just tried this in Firefox with an es locale and get 31 Dec 1969 19:00. So formatting works fine and the language is in English, not Spanish.

:shipit:

@josh
Copy link
Contributor Author

josh commented May 30, 2014

That was my initial assumption too.

On May 30, 2014, at 6:18 PM, David Graham notifications@github.com wrote:

Interesting. I thought the locale was required to get the date and time formats correct. But the locale is only used to detect the language the text appears in, not the formatting.

I just tried this in Firefox with an es locale and get 31 Dec 1969 19:00. So formatting works fine and the language is in English, not Spanish.


Reply to this email directly or view it on GitHub.

josh added a commit that referenced this pull request May 30, 2014
Use DefaultLocale by passing in `undefined`
@josh josh merged commit cea19a0 into master May 30, 2014
@josh josh deleted the undefine-locale branch May 31, 2014 19:09
@dgraham dgraham mentioned this pull request Jun 1, 2014
@josh josh added the i18n label Jun 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants