v1 fixes #89
Merged
v1 fixes #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes maximum call stack size exceeded.
|
Oops forgot about this:
e80897f fixes it. |
|
Oh man that Chrome bug has been 🐛 bugging me! |
josh
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #67. @josh I made 2 fixes here:
polymer.html. More on this 👇🏻This is a super weird Chrome bug that took away hours of my life 😭. While testing I noticed that it looks broken:
It doesn't happen in Safari. Turns out a bug has been filed: https://bugs.chromium.org/p/chromium/issues/detail?id=739417 Here's another test case I made: http://jsbin.com/xizojipoji/1/edit?html,output It seems like the original
textContentgets appended late when element is defined before use, so it can't be cleared/replaced because it didn't exist.cc @dgraham cause we talked about this.
Anyways all looks good now I think! ✨
Do you know if there's an efficient way to test the
setIntervalupdate forrelative-time? The broken callbacks didn't get caught by the test.