Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reply to PR-level comments #552

Open
github-product-roadmap opened this issue Aug 17, 2022 · 0 comments
Open

Reply to PR-level comments #552

github-product-roadmap opened this issue Aug 17, 2022 · 0 comments
Labels
all Product SKU: All ga Feature phase: Generally available pull requests Feature: Github Pull Requests server Available on Server

Comments

@github-product-roadmap
Copy link
Collaborator

Summary

Comments added to a pull request from the Conversation tab can be replied to, and the comment and its replies live together in the timeline. This avoids the need to use "Quote reply" to respond to a general pull request comment, which simply copied the text of the earlier comment and the comments could easily be separated from each other in the timeline (making it difficult for users to follow the conversation).

Image

Intended Outcome

  1. Easier for users to follow and participate in conversations since the comment and all replies live together
  2. Improve code quality by ensuring conversations are discoverable and optionally required to be resolved prior to merging

How will it work?

  1. User A posts a comment to a pull request from the Conversation tab
  2. Other activity happens on the pull request resulting in new items on the timeline
  3. User B replies to the earlier comment and this reply appears directly below the original comment
@github github locked and limited conversation to collaborators Aug 17, 2022
@github-product-roadmap github-product-roadmap added all Product SKU: All code Feature area: Code experiences ga Feature phase: Generally available server Available on Server labels Aug 17, 2022
@github-product-roadmap github-product-roadmap changed the title Reply to comments on a pull request Reply to PR-level comments Sep 14, 2022
@ankneis ankneis added the pull requests Feature: Github Pull Requests label Dec 21, 2022
@github-product-roadmap github-product-roadmap removed the code Feature area: Code experiences label Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
all Product SKU: All ga Feature phase: Generally available pull requests Feature: Github Pull Requests server Available on Server
Projects
GitHub public roadmap
Status: Future
Milestone
No milestone
Development

No branches or pull requests
2 participants
@github-product-roadmap @ankneis