Skip to content

Commit

Permalink
Remove version constraints for rubocop libraries
Browse files Browse the repository at this point in the history
These constraints make it more difficult to upgrade these libraries in
projects that use rubocop-github.

I think the idea here was that we'd be able to bump the version
alongside the default config, but without locking to an exact version we
can still end up with a config that is incompatible with certain rubocop
version (see the unrecognized cop error in
#86, for example).

If anything, I'd prefer a `>=` constraint over a `<=`. That would allow
us to bump the minimum constraint when we add new cops, but still
freely upgrade in our projects as long as there are no config
incompatibilities (which are less common anyway ever since RuboCop 1.0).
  • Loading branch information
composerinteralia committed Jan 11, 2022
1 parent 20e1ffc commit 286944a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions rubocop-github.gemspec
Expand Up @@ -10,9 +10,9 @@ Gem::Specification.new do |s|

s.files = Dir["README.md", "STYLEGUIDE.md", "LICENSE", "config/*.yml", "lib/**/*.rb", "guides/*.md"]

s.add_dependency "rubocop", "<= 1.13.0"
s.add_dependency "rubocop-performance", "<= 1.11.0"
s.add_dependency "rubocop-rails", "<= 2.7.1"
s.add_dependency "rubocop"
s.add_dependency "rubocop-performance"
s.add_dependency "rubocop-rails"

s.add_development_dependency "actionview", "~> 5.0"
s.add_development_dependency "minitest", "~> 5.14"
Expand Down

0 comments on commit 286944a

Please sign in to comment.