Marshalize mismatch errors #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements functionality to make MismatchErrors Marshalizeable.
|
Can we also drop a new patch version after this is merged? We need this change to fix some internal errors (at GitHub). |
zerowidth
reviewed
Nov 1, 2021
lib/scientist/experiment.rb
Outdated
| private | ||
|
|
||
| def marshalize(block) | ||
| def block._dump(_) |
There was a problem hiding this comment.
Could you add a check first before overriding? respond_to?(:_dump) || respond_to?(:_dump_data)
There was a problem hiding this comment.
Great idea. I'm working to add that.
There was a problem hiding this comment.
@zerowidth I added a check to this before overriding. Please let me know if you have any other feedback. 🙏
zerowidth
reviewed
Nov 4, 2021
|
|
||
| private | ||
|
|
||
| def marshalize(block) |
There was a problem hiding this comment.
Can you add a comment here explaining why we want to make everything marshalable?
There was a problem hiding this comment.
Good call. Added. 👌
zerowidth
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements functionality to make MismatchErrors Marshalizeable.