Allow setting raise_on_mismatches per Experiment instance #23
Conversation
tyamagu2
force-pushed
the
raise_if_mismatches_per_instance
branch
from
43d583b
to
eb94336
Compare
| @@ -269,4 +269,16 @@ def try(name = nil, &block) | |||
| def use(&block) | |||
| try "control", &block | |||
| end | |||
|
|
|||
| def raise_on_mismatches=(bool) | |||
There was a problem hiding this comment.
I might go with attr_accessor here instead, but continue to define the predicate method below.
| @@ -5,6 +5,9 @@ | |||
| # implements Scientist::Experiment's interface. | |||
| module Scientist::Experiment | |||
|
|
|||
| # Whether to raise when the control and candidate mismatch. | |||
There was a problem hiding this comment.
Can you document the default behavior?
There was a problem hiding this comment.
I did. Let me know if this is not what you wanted.
|
I'll rebase and squash if necessary, so let me know. |
|
@jesseplusplus @rick @zerowidth We let this one go stale. Final thoughts? |
|
I'm neither a rebaser nor a squasher. Seems 👍 to 🚢. |
Allow setting raise_on_mismatches per Experiment instance
|
@jesseplusplus @zerowidth @rick The API seems pretty stable, this is the first change we've merged in a while. How bout bumping to 1.0.0? |
|
@jbarnette Hmm, the master build failed CI after merging this. Looks like an issue installing the scientist gem while bundling before it even gets to the tests -- possibly related to a change in Travis' build environment for the older rubies since the last commit before merge passed with no troubles. |
|
@jesseplusplus Doh! I'll fix it up. |
This patch addresses #21. I also find this would be useful, so here's the patch.