Handle nil values and empty arrays #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because configs can be environment-based and some values may not be configured for an environment, don't raise an exception during validation for nil values.
And because arrays are compacted, arrays of nils would have the same effect
* will not allow data: blob: etc
oreoshake
added a commit
that referenced
this pull request
Dec 11, 2015
Handle nil values and empty arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an error where a nil value wouldn't pass the "arrays of strings" validation test. This came up when doing environment-specific configuration where values would be
nilwithoutcompacting the array.While testing this out, I also noticed that an empty array or array of
nils ([nil]which is compacted) would include the directive, but without any value.script_src: [nil]would producescript-src ;. That's bad.Also, I noticed that the code that minifies directives containing
*was incorrectly discardingdata:andblob:which are not covered by a*source.