Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: overrides were not carrying configuration values forward #239

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Regression: overrides were not carrying configuration values forward #239

merged 1 commit into from
Mar 30, 2016

Conversation

oreoshake
Copy link
Contributor

This meant that when header caches were regenerated upon calling SecureHeaders.override(:name) and using it with use_secure_headers_override would result in default values for anything other than CSP/HPKP.

@oreoshake oreoshake merged commit 96cd676 into master Mar 30, 2016
@oreoshake oreoshake deleted the fix-regression-with-overrides branch March 30, 2016 19:54
@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 96.266% when pulling 34c8129 on fix-regression-with-overrides into cd56394 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oreoshake @coveralls